Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

Added azureai client#36

Open
VindyaKonjarla wants to merge 6 commits intoray-project:mainfrom
VindyaKonjarla:main
Open

Added azureai client#36
VindyaKonjarla wants to merge 6 commits intoray-project:mainfrom
VindyaKonjarla:main

Conversation

@VindyaKonjarla
Copy link

@VindyaKonjarla VindyaKonjarla commented Feb 22, 2024

No description provided.

@xieus xieus requested a review from avnishn February 24, 2024 21:43
tot0
tot0 approved these changes Mar 7, 2024
View reviewed changes
README.md Outdated
### AzureAI Compatible APIs
```bash
export AZUREAI_API_KEY=secret_abcdefg
export AZUREAI_API_BASE="https://api.endpoints.anyscale.com/v1"
Copy link

@tot0 tot0 Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an example Azure AI endpoint instead of an anyscale endpoint?

Copy link
Author

@VindyaKonjarla VindyaKonjarla Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the API_BASE to .ai.azure.com

@VindyaKonjarla
Update README.md
036ff0a 
Signed-off-by: VindyaKonjarla <157361884+VindyaKonjarla@users.noreply.github.com>
@NicolasGrosjeanProbayes
Copy link

NicolasGrosjeanProbayes commented Mar 13, 2024

Is it normal there is no difference compared to OpenAIChatCompletionsClient except the name of used environment variables ?

Note : OPENAI_API_BASE and OPENAI_API_KEY were not renamed in the ValueError

@SameepPanigrahi
Update azureai_chat_completion.py
1ba6d22 
Signed-off-by: Sameep Kumar Panigrahi <59465094+SameepPanigrahi@users.noreply.github.com>
@VindyaKonjarla
Copy link
Author

VindyaKonjarla commented Mar 14, 2024 •
edited
Loading

Is it normal there is no difference compared to OpenAIChatCompletionsClient except the name of used environment variables ?

Note : OPENAI_API_BASE and OPENAI_API_KEY were not renamed in the ValueError

@NicolasGrosjeanProbayes , Updated the file for the ValueError. Please review.And on your question, that is expected.

@NicolasGrosjeanProbayes
Copy link

NicolasGrosjeanProbayes commented Mar 14, 2024

@NicolasGrosjeanProbayes , Updated the file for the ValueError. Please review.And on your question, that is expected.

I am a simple user, I have no write access, so my review will bring nothing.

I don't see the added value compared to OpenAI Compatible API if the code is the same.

Maybe I don't see the need to have the parameters in AZUREAI_API_KEY and AZUREAI_API_BASE variables instead of OPENAI_API_BASE and OPENAI_API_KEY variables. But even with this need, copying one hundred line of code doesn't seem a good idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@avnishn avnishn Awaiting requested review from avnishn

1 more reviewer

@tot0 tot0 tot0 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VindyaKonjarla @NicolasGrosjeanProbayes @tot0 @SameepPanigrahi